Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use deepcopy method for event #166

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Use deepcopy method for event #166

merged 1 commit into from
Mar 22, 2021

Conversation

somtochiama
Copy link
Member

Fixes: #163

Also removes pkg/recorder and uses pkg/runtime/events
Signed-off-by: Somtochi Onyekwere [email protected]

@stefanprodan stefanprodan added the area/alerting Alerting related issues and PRs label Mar 21, 2021
stefanprodan
stefanprodan approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama please rebase with main.

@somtochiama
Use deepcopy method for event
a99a0bc 
Signed-off-by: Somtochi Onyekwere <[email protected]>
@stefanprodan stefanprodan merged commit 7cbca8b into fluxcd:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/alerting Alerting related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different alerts mix up summary
2 participants
@somtochiama @stefanprodan