Send notification header identify requests as coming from the notification component. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/notifier/forwarder.go
Outdated
| @@ -40,7 +43,10 @@ func NewForwarder(hookURL string, proxyURL string) (*Forwarder, error) { | |||
| } | |||
|
|
|||
| func (f *Forwarder) Post(event recorder.Event) error { | |||
| err := postMessage(f.URL, f.ProxyURL, event) | |||
| err := postMessage(f.URL, f.ProxyURL, event, func(req *retryablehttp.Request) { | |||
| req.Header.Set("Notification-Controller", event.ReportingController) | |||
There was a problem hiding this comment.
Please extract the header name into a variable and rename it to gotk-component
This adds support for sending an HTTP header `gotk-component` with the originating controller, this can be identifed in receiving servers. Signed-off-by: Kevin McDermott <[email protected]>
phillebaba
reviewed
Nov 19, 2020
There was a problem hiding this comment.
I think this looks good, but I will let @stefanprodan have last say if he has any other comments.
stefanprodan
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for sending a Notification-Controller header from the forwarder notifier.
This means that it can be identified in upstream requests.