fixed ecr test, cleaning up

oci/auth/login/cache.go

@@ -17,6 +17,7 @@ limitations under the License.
 package login
 
 import (
+	"fmt"
 	"time"
 
 	"github.com/google/go-containerregistry/pkg/authn"
@@ -32,13 +33,20 @@ func cacheObject[T authn.Authenticator](store cache.Expirable[cache.StoreObject[
 
 	err := store.Set(obj)
 	if err != nil {
+		fmt.Println("error setting object", err)
 		return err
 	}
+	fmt.Println("object set")
 
 	return store.SetExpiration(obj, expiresAt)
 }
 
 func getObjectFromCache[T authn.Authenticator](cache cache.Expirable[cache.StoreObject[T]], key string) (T, bool, error) {
 	val, exists, err := cache.GetByKey(key)
+	keys, err := cache.ListKeys()
+	if err != nil {
+		return val.Object, false, err
+	}
+	fmt.Println("keys", keys)
 	return val.Object, exists, err
 }

oci/auth/login/login.go

@@ -164,11 +164,17 @@ func (m *Manager) Login(ctx context.Context, url string, ref name.Reference, opt
 
 	switch provider {
 	case oci.ProviderAWS:
+		fmt.Println("logging in to AWS ECR")
 		auth, expiresAt, err := m.ecr.LoginWithExpiry(ctx, opts.AwsAutoLogin, url)
+		fmt.Println("auth", auth)
+		fmt.Println("expiresAt", expiresAt)
+		fmt.Println("err", err)
 		if err != nil {
 			return nil, err
 		}
+		fmt.Println("opts.cache", opts.Cache)
 		if opts.Cache != nil {
+			fmt.Println("caching auth object")
 			err := cacheObject(opts.Cache, auth, key, expiresAt)
 			if err != nil {
 				logr.FromContextOrDiscard(ctx).Error(err, "failed to cache auth object")

oci/auth/login/login_test.go

@@ -201,7 +201,7 @@ func TestLogin_WithCache(t *testing.T) {
 	}{
 		{
 			name:         "ecr",
-			responseBody: fmt.Sprintf(`{"authorizationData": [{"authorizationToken": "c29tZS1rZXk6c29tZS1zZWNyZXQ=","expiresAt": "%s"}]}`, timestamp.Format(time.RFC3339)),
+			responseBody: fmt.Sprintf(`{"authorizationData": [{"authorizationToken": "c29tZS1rZXk6c29tZS1zZWNyZXQ=","expiresAt": %d}]}`, timestamp.Unix()),
 			providerOpts: ProviderOptions{AwsAutoLogin: true},
 			beforeFunc: func(serverURL string, mgr *Manager, image *string) {
 				// Create ECR client and configure the manager.