Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable '-race' for 'go test' #250

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Mar 20, 2022

Enables race condition checks during the execution of tests. This PR also fixes the only occurrency of racy condition found.

May relate to the TestGitRepositoryReconciler_reconcileSource_authStrategy failures in fluxcd/source-controller#615.

Paulo Gomes added 2 commits March 20, 2022 12:09
Prevent multiple ssh server initialisations with a mutex.

Signed-off-by: Paulo Gomes <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

@stefanprodan stefanprodan merged commit 372d2e0 into fluxcd:main Mar 21, 2022
@pjbgf pjbgf deleted the enable-test-race branch March 21, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants