Expose the default rate limiter #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
added
the
area/runtime
darkowlzz
force-pushed
the
default-rate-limiter
branch
from
7c91736
to
1982ac6
Compare
hiddeco
approved these changes
Jan 10, 2023
The default configurations for rate limiter is exposed only to flag set. This change adds a new function GetDefaultRateLimiter() to provide access to the same rate limiter configuration without flags. This is useful for setting the default rate limiter for reconcilers in test suites. Signed-off-by: Sunny <[email protected]>
darkowlzz
force-pushed
the
default-rate-limiter
branch
from
1982ac6
to
a9070db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default configurations for rate limiter is exposed only to flag set. This change adds a new function
GetDefaultRateLimiter()to provide access to the same rate limiter configuration without flags. This is useful for setting the default rate limiter for reconcilers in test suites.The default rate limiter configuration set in upstream client-go code has a very short minimum delay, which results in a flood of error logs in the tests when it's an expected behavior. Because the reconcilers are configured differently in the test suite and a properly deployed controller, there is a difference in the observed results. This change allows for the test and deployment configuration of the reconcilers to be similarly configured with the same default rate limiter.