Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git/gogit: add proxy support for pushing to remote #615

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented Aug 2, 2023

Add proxy support togogit.Client.Push().

Prerequisite to: fluxcd/image-automation-controller#565

Disable CGO for Git e2e tests as it was originially required because of
our libgit2 client. Since we no longer maintain a libgit2 client, there
is no need to run the tests with CGO enabled.

Signed-off-by: Sanskar Jaiswal <[email protected]>
@aryan9600 aryan9600 force-pushed the push-proxy branch 2 times, most recently from 7a58fdd to b8a2a03 Compare August 3, 2023 14:01
GitHub sometimes fails to push things using SSH due to weird and
mysterious deploy key errors, like
"unknown error: ERROR: Unknown public SSH key".

As a workaround, the intial push operation for each test case is
retried on failure for 20 seconds.

Signed-off-by: Sanskar Jaiswal <[email protected]>
@aryan9600 aryan9600 merged commit 6d61e1b into main Aug 3, 2023
13 checks passed
@aryan9600 aryan9600 deleted the push-proxy branch August 3, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants