Cache credentials tokens #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
reviewed
Jun 25, 2024
souleb
force-pushed
the
cache-key-fix
branch
2 times, most recently
from
0fd95c9
to
c8d33f6
Compare
darkowlzz
approved these changes
Jul 2, 2024
darkowlzz
reviewed
Jul 2, 2024
If implemented, a specific function is used to compute the key for caching credentials based on the provider way of requesting it. Signed-off-by: Soule BA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use the full
image urlas key for the cache. The new change introduced here reduce cardinality and permit reusing a cached credentials based onaws region,gcp projectandazure endpoint.