Upgrade go-git to v5.10.0
#1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
area/git
|
This doesn't seem to fix that issue, isn't the fix in go-git v5.10.0? |
makkes
force-pushed
the
upgrade-git-gogit
branch
from
efd1e0f
to
a523340
Compare
Ugh, I missed that go-git/go-git is also directly required here, too. Fixed. |
|
I shall add a regression test... |
makkes
force-pushed
the
upgrade-git-gogit
branch
from
a523340
to
04b8b3e
Compare
stefanprodan
approved these changes
Oct 30, 2023
|
It's really tought to add a proper regression test here because I'd bascially have to simulate the exact output from the SSH-Server. |
|
@makkes can you please rebase so we can merge this. Given that testing is quite complicated we can do this in a diffrent PR. |
fixes #1239 Signed-off-by: Max Jonas Werner <[email protected]>
makkes
force-pushed
the
upgrade-git-gogit
branch
from
04b8b3e
to
bbfe866
Compare
|
Rebased and created #1279 to track tests. |
pjbgf
approved these changes
Nov 9, 2023
|
@makkes can you please do the same update in image-automation-controller |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: go-git/go-git#866
fixes: #1239