Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated io/ioutil #409

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Drop deprecated io/ioutil #409

merged 1 commit into from
Jul 29, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jul 29, 2021

The package has been deprecated since Go 1.16, see:
https://golang.org/doc/go1.16#ioutil

Ref: fluxcd/flux2#1658

The package has been deprecated since Go 1.16, see:
https://golang.org/doc/go1.16#ioutil

Signed-off-by: Hidde Beydals <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can we do this for the cli and other controllers? Maybe an issues in flux2 with good-first-issue?

@hiddeco
Copy link
Member Author

hiddeco commented Jul 29, 2021

@stefanprodan created an issue and added a reference to the PR.

@hiddeco hiddeco merged commit 273f8b1 into main Jul 29, 2021
@hiddeco hiddeco deleted the dep-ioutil branch July 29, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants