libgit2: fix checkout logic for CheckoutBranch #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
reviewed
May 31, 2022
darkowlzz
reviewed
May 31, 2022
darkowlzz
reviewed
May 31, 2022
aryan9600
force-pushed
the
fix-checkout-branch
branch
from
f6a2024
to
775c3cd
Compare
darkowlzz
reviewed
May 31, 2022
aryan9600
force-pushed
the
fix-checkout-branch
branch
from
775c3cd
to
107ca31
Compare
aryan9600
added
area/git
darkowlzz
reviewed
May 31, 2022
aryan9600
force-pushed
the
fix-checkout-branch
branch
from
107ca31
to
601aa0f
Compare
hiddeco
approved these changes
Jun 1, 2022
darkowlzz
approved these changes
Jun 1, 2022
|
Please rebase so that we can merge it. |
Use the target commit, to checkout tree and set the head to the desired branch instead of doing a hard reset to the target commit. Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
fix-checkout-branch
branch
from
601aa0f
to
ae27f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the target commit, to checkout tree and set the head to the desired
branch instead of doing a hard reset to the target commit.
This fixes a regression introduced alongside optimized git clones logic, which would not checkout the repo to the specified branch. This does not affect
source-controller, but it does affect theimage-automation-controller, since it further uses the cloned repo, to commit changes and push to origin.Signed-off-by: Sanskar Jaiswal [email protected]