Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: fix gitlab redirection for HTTP #765

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Jun 7, 2022

Gitlab only supports HTTP redirection for GET operations,
and fails POST operations targeting a repository without
the .git suffix.

Relates to fluxcd/image-automation-controller#379

Gitlab only supports HTTP redirection for GET operations,
and fails POST operations targeting a repository without
the .git suffix.

Fixes: fluxcd/image-automation-controller#379
Signed-off-by: Paulo Gomes <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

@pjbgf pjbgf merged commit e70b365 into fluxcd:main Jun 7, 2022
@pjbgf pjbgf deleted the gitlab-dotgit-redirect branch June 7, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants