Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2/managed/http: test for incomplete creds #796

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

darkowlzz
Copy link
Contributor

Add test for createClientRequest() where the credentials are incomplete.

Follow up of #794

Add test for createClientRequest() where the credentials are incomplete.

Signed-off-by: Sunny <[email protected]>
@darkowlzz darkowlzz added area/git Git related issues and pull requests area/testing Testing related issues and pull requests labels Jun 23, 2022
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @darkowlzz 🙇

@stefanprodan stefanprodan merged commit 60cf11a into main Jun 24, 2022
@stefanprodan stefanprodan deleted the libgit2-req-incomplete-auth-test branch June 24, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests area/testing Testing related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants