Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openapi): full regex for url to prevent error #838

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

davinkevin
Copy link
Contributor

In IDEA, the previous pattern led to an error because the regex wasn't complete.

image

If there is some extra work to do, let me know.

Signed-off-by: Davin Kevin [email protected]

@hiddeco
Copy link
Member

hiddeco commented Jul 19, 2022

Thanks for your contribution! This Custom Resource Definition file is generated from Go code, and the change needs to be made here: https://github.com/fluxcd/source-controller/blob/main/api/v1beta2/gitrepository_types.go#L51.

After this, running make generate manifests in the repository root should update the file.

@davinkevin davinkevin force-pushed the fix-openapi-url branch 2 times, most recently from c50c448 to 85f0814 Compare July 19, 2022 12:00
@davinkevin
Copy link
Contributor Author

Thank you @hiddeco, I've made the modification. I was sure it was a generated file but I wasn't able to confirm it by reading the git history.

Should be ok now, make generate manifests was ok so we just need to wait for the CI now 👍.

@makkes
Copy link
Member

makkes commented Jul 19, 2022

It looks like the failing tests/test-linux-arm64 check is a flake but I kicked it off once more to be sure.

@hiddeco
Copy link
Member

hiddeco commented Jul 19, 2022

Do we have this type of check elsewhere? E.g. HelmRepository URL? As I think it has the same problem then.

@davinkevin
Copy link
Contributor Author

Do we have this type of check elsewhere? E.g. HelmRepository URL? As I think it has the same problem then.

Currently, there is no other +kubebuilder:validation:Pattern except those I've modified. It can be added, but maybe part of another PR.

@davinkevin
Copy link
Contributor Author

Can I do something to help with this blocked PR?

In IDEA, the previous pattern led to an error because the regex wasn't complete.

Signed-off-by: Davin Kevin <[email protected]>
@makkes makkes merged commit 3ad7bc9 into fluxcd:main Jul 22, 2022
@davinkevin
Copy link
Contributor Author

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants