Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom CA certificates to system certificates #904

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add custom CA certificates to system certificates #904

merged 1 commit into from
Sep 23, 2022

Commits on Sep 23, 2022

  1. add custom CA certificates to system certificates 

    When a custom CA certificate is provided in a Secret's `caCert` field
referenced in `HelmRelease.spec.secretRef` then that CA cert is now
added to the list of system certificates instead of it replacing the
system certificates. This makes HelmRepositories work in mixed
environments where charts are pulled from both, a public repository
and a private repository (e.g. through a chart dependency).

The test that is added as part of this change will fail without the
change and passes with it.

closes #866
closes fluxcd/helm-controller#519

Signed-off-by: Max Jonas Werner <[email protected]>
    @makkes @stefanprodan
    makkes authored and stefanprodan committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    7a13964 View commit details
    Browse the repository at this point in the history