Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collection lock file ignore tests #992

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Garbage collection lock file ignore tests #992

merged 2 commits into from
Dec 21, 2022

Conversation

darkowlzz
Copy link
Contributor

Follow-up of #991

  • Test that the lock files are ignored by the GC while processing the files.
  • Test that the lock files are deleted at the end of GC.
  • Replace path.Join() with filepath.Join() in storage tests.

@darkowlzz darkowlzz added area/storage Storage related issues and pull requests area/testing Testing related issues and pull requests labels Dec 20, 2022
@darkowlzz
test: Add tests for GC ignoring lock files
6134dd9 
Add storage tests to ensure garbage collection ignores lock files for GC
count and deletes them eventually.

Signed-off-by: Sunny <[email protected]>
@darkowlzz
Use filepath instead of path in storage tests
b115dda 
Signed-off-by: Sunny <[email protected]>
hiddeco
hiddeco approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @darkowlzz 🥇

@darkowlzz darkowlzz merged commit c741805 into main Dec 21, 2022
@darkowlzz darkowlzz deleted the gc-lock-tests branch December 21, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/storage Storage related issues and pull requests area/testing Testing related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkowlzz @hiddeco