build: update deps and ramda functions #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crash7
commented
Oct 13, 2022
src/remove.js
Outdated
Comment on lines
16
to
22
| const pipeP = pipeWith(andThen); | ||
|
|
||
| /** | ||
| * @private | ||
| */ | ||
| const removeAndUnwrapAttributes = deleteItem => pipeP(apply(deleteItem), unwrapProp('Attributes')); | ||
| const removeAndUnwrapAttributes = deleteItem => | ||
| pipeP([apply(deleteItem), unwrapProp('Attributes')]); |
There was a problem hiding this comment.
@nfantone does this makes sense to you? I can move the pipeP to a util folder before merging.
context: pipeP was removed on the last version
There was a problem hiding this comment.
Makes sense to me. Although, in hindsight, I would probably use a regular async function now.
There was a problem hiding this comment.
Something like this?
nfantone
approved these changes
Oct 19, 2022
nfantone
approved these changes
Nov 25, 2022
crash7
force-pushed
the
build/update-deps-ci
branch
from
010863e
to
2711a5c
Compare
|
➿ Code coverage
|
Closed
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.