-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(a380x): port fcu and make fixes #8919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
force-pushed
the
mrc-port-a380-fcu
branch
3 times, most recently
from
September 15, 2024 11:18
505debb
to
776f56c
Compare
Merged
tracernz
force-pushed
the
mrc-port-a380-fcu
branch
2 times, most recently
from
September 17, 2024 10:05
b3b1380
to
18635bb
Compare
The type errors are now all real.
tracernz
force-pushed
the
mrc-port-a380-fcu
branch
from
October 5, 2024 13:11
9e28e7f
to
ed9afaa
Compare
2hwk
previously requested changes
Oct 6, 2024
...src/base/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/panel/panel.xml
Show resolved
Hide resolved
Saschl
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You already added all the TODOs and FIXMEs so I'm happy when you are
Saschl
reviewed
Oct 11, 2024
2hwk
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8913
Summary of Changes
Ports the FCU. Steps:
Future work:
This also prepares for ADR work I am doing for the A32NX (and in relation to the FMGC/FCU work Lukas is doing).
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Test all functions of the FCU except metric altitude (not implemented).
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.