Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(a380x): port fcu and make fixes #8919

Merged
merged 25 commits into from
Oct 12, 2024

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Sep 15, 2024

Fixes #8913

Summary of Changes

Ports the FCU. Steps:

  • Copy code across essentially unmodified and get working.
  • Add type information with the actual types used. The type errors are now all real.
  • Split some systems code from UI code and refactor to MSFS avionics style.
  • Show pointer/VOR/ADF labels on the display depending on what's selected.
  • Fix baro pre-select forgetting the pre-selected value.

Future work:

  • Port the rest of the components to MSFS avionics style.

This also prepares for ADR work I am doing for the A32NX (and in relation to the FMGC/FCU work Lukas is doing).

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Test all functions of the FCU except metric altitude (not implemented).

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@tracernz tracernz added the Not Ready For Review Still draft but needs a GitHub build label Sep 15, 2024
@tracernz tracernz force-pushed the mrc-port-a380-fcu branch 3 times, most recently from 505debb to 776f56c Compare September 15, 2024 11:18
@tracernz tracernz mentioned this pull request Sep 15, 2024
@tracernz tracernz force-pushed the mrc-port-a380-fcu branch 2 times, most recently from b3b1380 to 18635bb Compare September 17, 2024 10:05
@aguther aguther added the A380X Related to the A380X aircraft label Sep 24, 2024
@tracernz tracernz requested a review from 2hwk October 9, 2024 08:32
@tracernz tracernz removed the Not Ready For Review Still draft but needs a GitHub build label Oct 9, 2024
Copy link
Contributor

@Saschl Saschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You already added all the TODOs and FIXMEs so I'm happy when you are

@tracernz tracernz merged commit 7c6f3d2 into flybywiresim:master Oct 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA Tier 1 Tested
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

A380X Baro preselection not remembering entered value
4 participants