Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x): MFD/SURV: Fix DEFAULT SETTINGS for TCAS #9454

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Nov 9, 2024

Summary of Changes

Fixes a bug where TCAS settings won't get set properly if you use the "DEFAULT SETTINGS" button (which should be used according to SOP). The radio buttons changed, but the new state wasn't transmitted to the TCAS (code wasn't adapted when adding TCAS).

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

No full flight neccessary:
Start at gate, set up aircraft for normal A-B flight. No full FMS setup needed, but you can do so if you want to. Before pushback, navigate to MFD/SURV and click on "DEFAULT SETTINGS". TCAS should now switch to TA/RA (verify that SimVar L:A32NX_TCAS_MODE switches to 2). Pushback, and taxi to runway, TCAS should remain in TA/RA and NORM, there should be no ECAM memo concerning TCAS.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft MFD labels Nov 9, 2024
@flogross89 flogross89 requested a review from 2hwk November 9, 2024 01:24
@flogross89 flogross89 added this to the v0.13.0 milestone Nov 9, 2024
@flogross89 flogross89 modified the milestones: v0.13.0, v0.12.3 Nov 9, 2024
@2hwk
Copy link
Member

2hwk commented Nov 10, 2024

Quality Assurance Report

Discord Username: 2cas
Object of testing: #9454
Aircraft: A380X
Tier of Testing: 1
Date: 10/11/2024

Testing Process:

  • Start at gate, set up aircraft for normal A-B flight.
  • No full FMS setup
  • Before pushback, navigate to MFD/SURV and click on "DEFAULT SETTINGS".
  • Waited for ADIRS to align
  • TCAS should now switch to TA/RA (verify that SimVar L:A32NX_TCAS_MODE switches to 2).
  • Pushback, and taxi to runway, TCAS should remain in TA/RA and NORM, there should be no ECAM memo concerning TCAS.
  • Retried with hitting "DEFAULT SETTINGS" before ADIRS aligned. ECAM memo did not appear.

Testing Results:
QA Passed

Negatives:

  • N/A

Conclusions:
LGTM

@alepouna alepouna enabled auto-merge (squash) November 10, 2024 10:39
@alepouna alepouna merged commit 2ffdaa4 into flybywiresim:master Nov 10, 2024
8 checks passed
flogross89 added a commit that referenced this pull request Nov 10, 2024
* fix DEFAULT SETTINGS for TCAS

* changelog

---------

Co-authored-by: 2hwk <[email protected]>
(cherry picked from commit 2ffdaa4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft MFD QA A380 Only QA only for A380 required QA Passed QA Ready to Test QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants