This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR implements deletion of artifacts from datacatalog's database as well as underlying blob storage.
Type
Are all requirements met?
Complete description
Datacatalog now supports deletion of artifacts (either via tag or artifact ID), removing the entry from the DB as well as underlying blob storage. Additional prometheus metrics for deletion have been added as well.
This is required for evicting the cache of past executions via flyteadmin.
The PR was created as a draft until the flyteidl and flytestdlib PRs have been merged and respective versions have been published.
Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA