Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FlyteCtl] Create LaunchPlan #392

Open
brucearctor opened this issue Jul 9, 2020 · 7 comments
Open

[FlyteCtl] Create LaunchPlan #392

brucearctor opened this issue Jul 9, 2020 · 7 comments
Assignees
@pmahindrakar-oss
Labels
enhancement New feature or request flytectl Issues related to flytectl -Flytes CLI good first issue Good for newcomers stale

Comments

@brucearctor
Copy link
Contributor

brucearctor commented Jul 9, 2020 •
edited by kumare3
Loading

Flytectl should support creating new launchplans directly - probably using a yaml or on commandline

flytectl create launchplan -f x.yaml

This is because it is possible to create launchplans that are not created in the SDK
@brucearctor brucearctor added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jul 9, 2020
@kumare3 kumare3 added good first issue Good for newcomers help wanted Extra attention is needed and removed untriaged This issues has not yet been looked at by the Maintainers labels Jul 9, 2020
@kumare3 kumare3 added this to the 0.11.0 milestone Jan 29, 2021
@kumare3 kumare3 added flytectl Issues related to flytectl -Flytes CLI and removed help wanted Extra attention is needed labels Feb 9, 2021
@EngHabu EngHabu modified the milestones: 0.11.0, 0.12.0 Mar 3, 2021
@EngHabu EngHabu modified the milestones: 0.12.0, 0.13.0 Apr 1, 2021
@kumare3 kumare3 modified the milestones: 0.13.0, 0.14.0 May 5, 2021
@kumare3
Copy link
Contributor

kumare3 commented May 5, 2021

@pmahindrakar-oss can you take a look at this? We also need a way to get details of a specific workflow + version and task + version

@kumare3 kumare3 modified the milestones: 0.14.0, 0.15.0 Jun 6, 2021
@EngHabu EngHabu modified the milestones: 0.15.0, 0.16.0 Jul 7, 2021
@pmahindrakar-oss
Copy link
Contributor

This is supported through register command where you can specify an archive or folder of serialized protobuf files of launchplans, tasks and workflows.

Also we support get on these entities for specific identity which includes project domain name and version of the entity

@EngHabu EngHabu modified the milestones: 0.16.0, 0.15.0 Jul 7, 2021
@kumare3 kumare3 reopened this Jul 7, 2021
@kumare3 kumare3 modified the milestones: 0.15.0, 0.16.0 Jul 7, 2021
@EngHabu EngHabu modified the milestones: 0.16.0, 0.17.0 Aug 2, 2021
@EngHabu EngHabu removed this from the 0.17.0 milestone Aug 31, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu
Always register the metadata endpoint (flyteorg#392)
f04414e 
* Always register the metadata endpoint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Rename

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Using released flyteidl

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Initialize authz metadata server

Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
Revert "Always register the metadata endpoint (flyteorg#392)" (flyteo…
33dd675 
…rg#403)

This reverts commit f04414e.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Revert "chore: remove redundant docker build on merge to master (flyt…
fb564f3 
…eorg#390)" (flyteorg#392)

This reverts commit 46db242.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot
chore(release): Release 0.52.1 [skip ci]
3911651 
## [0.52.1](http://github.com/lyft/flyteconsole/compare/v0.52.0...v0.52.1) (2022-04-15)

### Reverts

* Revert "chore: remove redundant docker build on merge to master (flyteorg#390)" (flyteorg#392) ([fb564f3](http://github.com/lyft/flyteconsole/commit/fb564f33c490859ecb7b2cfb4c3a6a6294de3530)), closes [flyteorg#390](http://github.com/lyft/flyteconsole/issues/390) [flyteorg#392](http://github.com/lyft/flyteconsole/issues/392)
@nadasaiyed
Copy link

nadasaiyed commented Jan 16, 2023 •
edited
Loading

Has there been any update on this? We would also benefit from such a command which can create launch plans during registration without having to package the launchplans.

@kumare3
Copy link
Contributor

kumare3 commented Jan 16, 2023

Would you be open to contributing?

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Always register the metadata endpoint (flyteorg#392)
0730c0e 
* Always register the metadata endpoint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Rename

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Using released flyteidl

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Initialize authz metadata server

Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
Revert "Always register the metadata endpoint (flyteorg#392)" (flyteo…
9ff1384 
…rg#403)

This reverts commit 0730c0e.
eapolinario added a commit that referenced this issue Sep 8, 2023
@eapolinario
Rust pb (#392)
18a2b9e 
* Generate rust protobuf using buf

Signed-off-by: eduardo apolinario <[email protected]>

* Commit generated rust code

Signed-off-by: eduardo apolinario <[email protected]>

---------

Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
eapolinario added a commit that referenced this issue Sep 13, 2023
@eapolinario
Rust pb (#392)
8492972 
* Generate rust protobuf using buf

Signed-off-by: eduardo apolinario <[email protected]>

* Commit generated rust code

Signed-off-by: eduardo apolinario <[email protected]>

---------

Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 26, 2023
@pingsutw
Mark webapi task failure as retry limit exceeded (#392)
caeaf5c 
Signed-off-by: Kevin Su <[email protected]>
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Oct 14, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
pvditt pushed a commit that referenced this issue Dec 29, 2023
@eapolinario
Rust pb (#392)
c36e738 
* Generate rust protobuf using buf

Signed-off-by: eduardo apolinario <[email protected]>

* Commit generated rust code

Signed-off-by: eduardo apolinario <[email protected]>

---------

Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
@github-actions GitHub Actions
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmahindrakar-oss pmahindrakar-oss

Labels
enhancement New feature or request flytectl Issues related to flytectl -Flytes CLI good first issue Good for newcomers stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@EngHabu @eapolinario @brucearctor @kumare3 @nadasaiyed @pmahindrakar-oss