Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete SageMaker Flytesnack #458

Closed
bnsblue opened this issue Aug 5, 2020 · 0 comments
Closed

Complete SageMaker Flytesnack #458

bnsblue opened this issue Aug 5, 2020 · 0 comments
Assignees
@kumare3
Labels
documentation Improvements or additions to documentation
Milestone
0.8.0

Comments

@bnsblue
Copy link
Contributor

bnsblue commented Aug 5, 2020

No description provided.

@EngHabu EngHabu added this to the 0.7.0 milestone Aug 5, 2020
@bnsblue bnsblue added the documentation Improvements or additions to documentation label Aug 5, 2020
@bnsblue bnsblue assigned kumare3 and unassigned bnsblue Aug 24, 2020
@kumare3 kumare3 modified the milestones: 0.7.0, 0.8.0 Sep 2, 2020
@bnsblue bnsblue closed this as completed Sep 3, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@ckiosidis @hamersaw
offload the WorkflowClosure to storage for flytepropeller (flyteorg#458)
b19ab2a 
* store separate crds parts to json files

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* use single object for static execution

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* make offloading configurable from flyteadmin config

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* empty crd fields when offloaded to storage

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* offload workflowClosure instead of parts of crd

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* use open flytepropeller with new crd fields

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* lint

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* pass config rather than argument and reuse datastore proto write function

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* cleanup

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fixed tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* setting crd closure reference to existing metastore data

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added test for stripping static fields on offload

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* rename offload config

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fix lint

Signed-off-by: Babis Kiosidis <[email protected]>

* upgrade flytepropeller version

Signed-off-by: Babis Kiosidis <[email protected]>

* goimports pkg/runtime/application_config_provider.go

Signed-off-by: Babis Kiosidis <[email protected]>

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Co-authored-by: Babis Kiosidis <[email protected]>
Co-authored-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@samhita-alla
Add code examples and update docs (flyteorg#458)
db714d4 
* Add code examples and update docs

Signed-off-by: Samhita Alla <[email protected]>

* update docs

Signed-off-by: Samhita Alla <[email protected]>

* spark readme

Signed-off-by: Samhita Alla <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@anrusina
chore: Provide basic repo structure and ensure that stories, tests, v…
86d5636 
…scode setup properly (flyteorg#458)

* chore: separate AppInfo
* chore: vscode properly understands @flyteconsole
* chore: add basics/locale entry
* test: add storybooks and tests
* test: fix istanbul test-coverage issue by binding babel versions

Signed-off-by: Nastya Rusina <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@ckiosidis @hamersaw
offload the WorkflowClosure to storage for flytepropeller (flyteorg#458)
bd3950c 
* store separate crds parts to json files

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* use single object for static execution

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* make offloading configurable from flyteadmin config

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* empty crd fields when offloaded to storage

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* offload workflowClosure instead of parts of crd

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* use open flytepropeller with new crd fields

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* lint

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* pass config rather than argument and reuse datastore proto write function

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* cleanup

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fixed tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* setting crd closure reference to existing metastore data

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* added test for stripping static fields on offload

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* rename offload config

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>

* fix lint

Signed-off-by: Babis Kiosidis <[email protected]>

* upgrade flytepropeller version

Signed-off-by: Babis Kiosidis <[email protected]>

* goimports pkg/runtime/application_config_provider.go

Signed-off-by: Babis Kiosidis <[email protected]>

Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Babis Kiosidis <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Co-authored-by: Babis Kiosidis <[email protected]>
Co-authored-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@ppiegaze
Update docs for flytectl update project (flyteorg#458)
246745d 
* project-archive-with-yaml

Signed-off-by: Peeter Piegaze <[email protected]>

* fix syntax

Signed-off-by: Peeter Piegaze <[email protected]>

* fix list

Signed-off-by: Peeter Piegaze <[email protected]>

* update generated

Signed-off-by: Peeter Piegaze <[email protected]>

---------

Signed-off-by: Peeter Piegaze <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@ppiegaze
Update docs for flytectl update project (flyteorg#458)
9feeb8e 
* project-archive-with-yaml

Signed-off-by: Peeter Piegaze <[email protected]>

* fix syntax

Signed-off-by: Peeter Piegaze <[email protected]>

* fix list

Signed-off-by: Peeter Piegaze <[email protected]>

* update generated

Signed-off-by: Peeter Piegaze <[email protected]>

---------

Signed-off-by: Peeter Piegaze <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@ppiegaze @austin362667
Update docs for flytectl update project (flyteorg#458)
07b067d 
* project-archive-with-yaml

Signed-off-by: Peeter Piegaze <[email protected]>

* fix syntax

Signed-off-by: Peeter Piegaze <[email protected]>

* fix list

Signed-off-by: Peeter Piegaze <[email protected]>

* update generated

Signed-off-by: Peeter Piegaze <[email protected]>

---------

Signed-off-by: Peeter Piegaze <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@ppiegaze @robert-ulbrich-mercedes-benz
Update docs for flytectl update project (flyteorg#458)
b8a564b 
* project-archive-with-yaml

Signed-off-by: Peeter Piegaze <[email protected]>

* fix syntax

Signed-off-by: Peeter Piegaze <[email protected]>

* fix list

Signed-off-by: Peeter Piegaze <[email protected]>

* update generated

Signed-off-by: Peeter Piegaze <[email protected]>

---------

Signed-off-by: Peeter Piegaze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumare3 kumare3

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@EngHabu @bnsblue @kumare3