Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run sync cluster resources as a goroutine in sandbox #1231

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Run sync cluster resources as a goroutine in sandbox #1231

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8210d82
sandbox
katrogan Jul 9, 2021
9b94dbd
1m
katrogan Jul 9, 2021
550efab
amazing progress
katrogan Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions deployment/eks/flyte_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8121,7 +8121,7 @@ data:
value: "4"
- projectQuotaMemory:
value: "3000Mi"
refresh: 5m
refreshInterval: 5m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this 1 minute?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

db.yaml: |
database:
port: 5432
Expand Down Expand Up @@ -8218,7 +8218,7 @@ data:
gpu: 1
kind: ConfigMap
metadata:
name: flyte-admin-config-dck98m94b6
name: flyte-admin-config-b6598mtg2d
namespace: flyte
---
apiVersion: v1
Expand Down Expand Up @@ -8849,7 +8849,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-dck98m94b6
name: flyte-admin-config-b6598mtg2d
name: config-volume
- configMap:
name: clusterresource-template-tkdkkt4cb5
Expand Down Expand Up @@ -9137,7 +9137,7 @@ spec:
name: clusterresource-template-tkdkkt4cb5
name: resource-templates
- configMap:
name: flyte-admin-config-dck98m94b6
name: flyte-admin-config-b6598mtg2d
name: config-volume
- name: db-pass
secret:
Expand Down
8 changes: 4 additions & 4 deletions deployment/gcp/flyte_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8119,7 +8119,7 @@ data:
value: "4"
- projectQuotaMemory:
value: "3000Mi"
refresh: 5m
refreshInterval: 5m
db.yaml: |
database:
port: 5432
Expand Down Expand Up @@ -8217,7 +8217,7 @@ data:
gpu: 1
kind: ConfigMap
metadata:
name: flyte-admin-config-864hmfdc2m
name: flyte-admin-config-hgfd27g4bd
namespace: flyte
---
apiVersion: v1
Expand Down Expand Up @@ -8891,7 +8891,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-864hmfdc2m
name: flyte-admin-config-hgfd27g4bd
name: config-volume
- configMap:
name: clusterresource-template-tkdkkt4cb5
Expand Down Expand Up @@ -9179,7 +9179,7 @@ spec:
name: clusterresource-template-tkdkkt4cb5
name: resource-templates
- configMap:
name: flyte-admin-config-864hmfdc2m
name: flyte-admin-config-hgfd27g4bd
name: config-volume
- name: db-pass
secret:
Expand Down
22 changes: 18 additions & 4 deletions deployment/sandbox/flyte_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,7 +2133,7 @@ data:
value: "4"
- projectQuotaMemory:
value: "3000Mi"
refresh: 5m
refreshInterval: 5m
db.yaml: |
database:
port: 5432
Expand Down Expand Up @@ -2222,7 +2222,7 @@ data:
gpu: 1
kind: ConfigMap
metadata:
name: flyte-admin-config-7gmg5ffhdd
name: flyte-admin-config-hg87cttf8m
namespace: flyte
---
apiVersion: v1
Expand Down Expand Up @@ -2903,6 +2903,20 @@ spec:
name: db-pass
- mountPath: /etc/secrets/
name: auth
- command:
- flyteadmin
- --config
- /etc/flyte/config/*.yaml
- clusterresource
- run
image: cr.flyte.org/flyteorg/flyteadmin:v0.6.10
imagePullPolicy: IfNotPresent
name: sync-cluster-resources-goroutine
volumeMounts:
- mountPath: /etc/flyte/clusterresource/templates
name: resource-templates
- mountPath: /etc/flyte/config
name: config-volume
- command:
- sh
- -c
Expand Down Expand Up @@ -3000,7 +3014,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-7gmg5ffhdd
name: flyte-admin-config-hg87cttf8m
name: config-volume
- name: db-pass
secret:
Expand Down Expand Up @@ -3412,7 +3426,7 @@ spec:
name: clusterresource-template-dtg8ff28mt
name: resource-templates
- configMap:
name: flyte-admin-config-7gmg5ffhdd
name: flyte-admin-config-hg87cttf8m
name: config-volume
- name: db-pass
secret:
Expand Down
6 changes: 3 additions & 3 deletions deployment/test/flyte_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ data:
value: "4"
- projectQuotaMemory:
value: "3000Mi"
refresh: 5m
refreshInterval: 5m
db.yaml: |
database:
port: 5432
Expand Down Expand Up @@ -370,7 +370,7 @@ data:
gpu: 1
kind: ConfigMap
metadata:
name: flyte-admin-config-g5mt4b25k8
name: flyte-admin-config-fk254ggftb
namespace: flyte
---
apiVersion: v1
Expand Down Expand Up @@ -854,7 +854,7 @@ spec:
- emptyDir: {}
name: shared-data
- configMap:
name: flyte-admin-config-g5mt4b25k8
name: flyte-admin-config-fk254ggftb
name: config-volume
- name: db-pass
secret:
Expand Down
1 change: 1 addition & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,7 @@ cluster_resource_manager:
# -- ClusterResource parameters
# Refer to the [structure](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/runtime/interfaces#ClusterResourceConfig) to customize.
cluster_resources:
refreshInterval: 5m
templatePath: "/etc/flyte/clusterresource/templates"
customData:
- production:
Expand Down
2 changes: 1 addition & 1 deletion kustomize/base/single_cluster/headless/config/admin/cluster_resources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ cluster_resources:
value: "4"
- projectQuotaMemory:
value: "3000Mi"
refresh: 5m
refreshInterval: 5m
17 changes: 17 additions & 0 deletions kustomize/overlays/sandbox/flyte/admin/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,23 @@ spec:
memory: "200Mi"
cpu: "0.1"
ephemeral-storage: "100Mi"
- name: sync-cluster-resources-goroutine
image: flyteadmin:v0.4.13
imagePullPolicy: IfNotPresent
command:
[
"flyteadmin",
"--config",
"/etc/flyte/config/*.yaml",
"clusterresource",
"run",
]
volumeMounts:
- name: resource-templates
mountPath: /etc/flyte/clusterresource/templates
- name: config-volume
mountPath: /etc/flyte/config

---
apiVersion: v1
kind: Service
Expand Down