Moving from flyteplugins - Feat: Expose nodeID to container #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Keck <[email protected]>
Signed-off-by: Dennis Keck <[email protected]>
…epo-move/flyteplugins/expose-node-id
8 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4135 +/- ##
==========================================
+ Coverage 58.98% 59.30% +0.32%
==========================================
Files 619 550 -69
Lines 52804 39700 -13104
==========================================
- Hits 31146 23545 -7601
+ Misses 19174 13834 -5340
+ Partials 2484 2321 -163
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Will open a new PR once I were able to refactor it in such a way that the ID is the same as displayed in the UI (without truncation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Exposes the NodeId to the kubernetes Pod as environment variable.
Type
Are all requirements met?
Complete description
Currently the environment variables do not provide enough information to know the exact task being executed.
For example we intended to create a unique ID for all retries of a task. Without the nodeID this is not possible as tasks might be reused.
One can retrieve this information also from the hostname but this fails for long names due to k8s pod name length limits.