Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert add supported task types for agent service by default for task types #4162

Conversation

Future-Outlier
Copy link
Member

Tracking issue

flyteorg/flyteplugins#412
flyteorg/flytepropeller#625

Describe your changes

As title.

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Future Outlier and others added 15 commits September 4, 2023 23:07
Signed-off-by: Future Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (b35cc95) 58.98% compared to head (a3495a4) 59.31%.
Report is 7 commits behind head on master.

❗ Current head a3495a4 differs from pull request most recent head 562a7c2. Consider uploading reports for the commit 562a7c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4162      +/-   ##
==========================================
+ Coverage   58.98%   59.31%   +0.33%     
==========================================
  Files         618      550      -68     
  Lines       52708    39692   -13016     
==========================================
- Hits        31088    23544    -7544     
+ Misses      19140    13828    -5312     
+ Partials     2480     2320     -160     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...yteplugins/go/tasks/plugins/webapi/agent/config.go 100.00% <ø> (ø)
...ropeller/pkg/controller/executors/dag_structure.go 100.00% <ø> (ø)
...ller/pkg/controller/executors/execution_context.go 58.06% <ø> (-0.76%) ⬇️
flytepropeller/pkg/controller/executors/kube.go 37.93% <ø> (+1.81%) ⬆️
...epropeller/pkg/controller/executors/node_lookup.go 77.77% <ø> (-2.23%) ⬇️
...lytepropeller/pkg/controller/nodes/task/handler.go 60.55% <100.00%> (+1.90%) ⬆️
...opeller/pkg/controller/nodes/task/plugin_config.go 94.59% <100.00%> (+1.41%) ⬆️
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 68.53% <50.00%> (+2.48%) ⬆️
flytepropeller/pkg/controller/controller.go 11.56% <0.00%> (-0.19%) ⬇️
...propeller/pkg/controller/nodes/task/transformer.go 79.31% <61.11%> (+2.44%) ⬆️
... and 2 more

... and 545 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit a9f5d24 into flyteorg:master Oct 4, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants