Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache evicted status #4705

Merged
merged 1 commit into from
Jan 10, 2024
Merged

add cache evicted status #4705

merged 1 commit into from
Jan 10, 2024

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Jan 9, 2024

Tracking issue

#2867

Why are the changes needed?

Need to add a new cache status as part of this PR. Returning a new cache status will break console so I figured updating CacheStatus idl -> updating console -> adding in task eviction endpoint made sense.

What changes were proposed in this pull request?

Add "CACHE_EVICTED" CacheStatus

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Paul Dittamo <[email protected]>
@pvditt pvditt marked this pull request as ready for review January 9, 2024 22:24
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jan 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d86f919) 58.15% compared to head (63388bc) 58.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4705      +/-   ##
==========================================
- Coverage   58.15%   58.12%   -0.03%     
==========================================
  Files         626      626              
  Lines       53786    53786              
==========================================
- Hits        31277    31265      -12     
- Misses      20001    20013      +12     
  Partials     2508     2508              
Flag Coverage Δ
unittests 58.12% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvditt pvditt merged commit 4ed13d0 into master Jan 10, 2024
44 of 45 checks passed
@pvditt pvditt deleted the add-cache-evict-status branch January 10, 2024 17:14
katrogan pushed a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants