Fixup flytectl #5309
Merged
Fixup flytectl #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
|
The expectation is that the flytectl unit tests are going to fail. |
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5309 +/- ##
==========================================
+ Coverage 59.68% 60.20% +0.51%
==========================================
Files 568 646 +78
Lines 41729 45654 +3925
==========================================
+ Hits 24906 27486 +2580
- Misses 14410 15576 +1166
- Partials 2413 2592 +179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
katrogan
previously approved these changes
May 2, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
pmahindrakar-oss
approved these changes
May 2, 2024
|
🎉 |
austin362667
pushed a commit
to austin362667/flyte
that referenced
this pull request
May 7, 2024
* Fix up flytectl Signed-off-by: Eduardo Apolinario <[email protected]> * Rename module and fix references Signed-off-by: Eduardo Apolinario <[email protected]> * Hook up linting and unit tests Signed-off-by: Eduardo Apolinario <[email protected]> * Remove boilerplate directory Signed-off-by: Eduardo Apolinario <[email protected]> * Include flytectl in the go-checks gh job Signed-off-by: Eduardo Apolinario <[email protected]> * Fix a few unit tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix more tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix more tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix graphviz test Signed-off-by: Eduardo Apolinario <[email protected]> * Reorder test in graphviz_test Signed-off-by: Eduardo Apolinario <[email protected]> * Remove -race from unit tests temporarily Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
8 tasks
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* Fix up flytectl Signed-off-by: Eduardo Apolinario <[email protected]> * Rename module and fix references Signed-off-by: Eduardo Apolinario <[email protected]> * Hook up linting and unit tests Signed-off-by: Eduardo Apolinario <[email protected]> * Remove boilerplate directory Signed-off-by: Eduardo Apolinario <[email protected]> * Include flytectl in the go-checks gh job Signed-off-by: Eduardo Apolinario <[email protected]> * Fix a few unit tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix more tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix more tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix graphviz test Signed-off-by: Eduardo Apolinario <[email protected]> * Reorder test in graphviz_test Signed-off-by: Eduardo Apolinario <[email protected]> * Remove -race from unit tests temporarily Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR brings the necessary changes to run flytectl CI changes in accordance with the model defined for the other components in the monorepo, including bumping the version of go (from 1.19 to 1.21).
This PR also renames the flytectl module and all its internal imports.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link