Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly setting execution environments in flyteidl #5323

Merged
merged 1 commit into from
May 3, 2024

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented May 3, 2024

Tracking issue

NA

Why are the changes needed?

Execution environments require assignments to be passed at runtime.

What changes were proposed in this pull request?

Enable setting execution environments through flyteadmin protos.

How was this patch tested?

Locally.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#5311

Docs link

NA

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.19%. Comparing base (f59e5ae) to head (f3dcae3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5323   +/-   ##
=======================================
  Coverage   60.19%   60.19%           
=======================================
  Files         646      646           
  Lines       45654    45654           
=======================================
  Hits        27481    27481           
  Misses      15581    15581           
  Partials     2592     2592           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.78% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw hamersaw merged commit 8cc9617 into master May 3, 2024
50 of 51 checks passed
@hamersaw hamersaw deleted the feature/execution-env-assignments branch May 3, 2024 16:18
austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants