-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[monorepo] Move flytectl gh workflows to monorepo #5354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5354 +/- ##
==========================================
+ Coverage 60.62% 61.09% +0.47%
==========================================
Files 776 794 +18
Lines 49918 51213 +1295
==========================================
+ Hits 30262 31289 +1027
- Misses 16839 17043 +204
- Partials 2817 2881 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
changed the title
[monorepo] Add goreleaser dry-run job for flytectl
[monorepo] Move flytectl gh workflows to monorepo
May 13, 2024
8 tasks
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
wild-endeavor
approved these changes
May 15, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* [flytectl] Add goreleaser dry-run job Signed-off-by: Eduardo Apolinario <[email protected]> * Use actions/checkout@v4 Signed-off-by: Eduardo Apolinario <[email protected]> * Add sandbox test and flytectl-release gh workflow Signed-off-by: Eduardo Apolinario <[email protected]> * Skip flyteidl release if releasing flytectl Signed-off-by: Eduardo Apolinario <[email protected]> * Add github token to flytectl release gh workflow Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
troychiu
pushed a commit
that referenced
this pull request
Jul 8, 2024
* [flytectl] Add goreleaser dry-run job Signed-off-by: Eduardo Apolinario <[email protected]> * Use actions/checkout@v4 Signed-off-by: Eduardo Apolinario <[email protected]> * Add sandbox test and flytectl-release gh workflow Signed-off-by: Eduardo Apolinario <[email protected]> * Skip flyteidl release if releasing flytectl Signed-off-by: Eduardo Apolinario <[email protected]> * Add github token to flytectl release gh workflow Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
We need to be able to release flytectl from the monorepo, this includes the CI checks used to validate the changes.
What changes were proposed in this pull request?
This PR adds the validation CI tests to run at regular PR time and also a specific gh workflow that will watch for tags of a specific format to run the actual flytectl release.
Notice that we moved to
goreleaser-pro
as the driver, this simplifies the process of releasing from a monorepo immensely (you just have to look the changes needed in flytectl/.goreleaser.yml).The release process for
flytectl
will involve creating a tag with a specific format, e.g. in order to release version 1.2.3 of theflytectl
we should push a tag likeflytectl/v1.2.3
. Notice thatflytectl
is going to be versioned separately from the backend components.How was this patch tested?
I used https://github.com/nektos/act to run this github job locally.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link