Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Put testdata together with test cases #123

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Put testdata together with test cases #123

merged 1 commit into from
Sep 8, 2020

Conversation

honnix
Copy link
Member

@honnix honnix commented Sep 7, 2020

TL;DR

Put testdata folder together we test cases using it.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

I moved the folder and updated test code accordingly.

Tracking Issue

flyteorg/flyte#502

Follow-up issue

#122 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   62.24%   62.24%           
=======================================
  Files         105      105           
  Lines        7840     7840           
=======================================
  Hits         4880     4880           
  Misses       2385     2385           
  Partials      575      575           
Flag Coverage Δ
#unittests 62.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e2c136...4859b6a. Read the comment docs.

@honnix honnix merged commit 581d63d into master Sep 8, 2020
schottra added a commit that referenced this pull request Sep 8, 2020
* origin/master:
  #patch Allow unscoped filtering on all NamedEntity(Metadata) fields (#124)
  Put testdata together with test cases (#123)
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants