Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes reference errors after dependency upgrades #46

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Feb 18, 2020

flyteorg/flyte#182
The update to @date-io/moment made it incompatible with moment.utc due to a direct reference made to .weekdaysShort, which won't exist on the object we are passing. (See this change)

For now, I've fixed the version to the last known working version. We can do an explicit update to the latest version later on, as it will also involve updating material-pickers.

flyteorg/flyte#179
d3-dag made some backwards incompatible renames between 0.1 and 0.2. I updated our local type definitions and the reference to dratify.

@schottra schottra merged commit 9bc2bc3 into master Feb 18, 2020
@schottra schottra deleted the bad-dependencies branch February 18, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants