Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add schedules to entity details #879

Merged
merged 1 commit into from
May 31, 2024

Conversation

jsonporter
Copy link
Contributor

Overview

This PR adds UI for viewing any schedules currently bound to an entity.

Screenshot 2024-05-31 at 9 40 30 AM

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@jsonporter jsonporter changed the title feat:Add schedules to entity details feat: Add schedules to entity details May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.72%. Comparing base (e179b51) to head (b1e21c8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
+ Coverage   54.56%   54.72%   +0.15%     
==========================================
  Files         583      583              
  Lines       15243    15246       +3     
  Branches     2783     2785       +2     
==========================================
+ Hits         8318     8343      +25     
+ Misses       6925     6903      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrankFlitton FrankFlitton merged commit c74e22e into master May 31, 2024
9 checks passed
@FrankFlitton FrankFlitton deleted the json/entity-details-schedules branch May 31, 2024 17:04
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants