This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add AgentService SyncAgent proto to the idl #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Future-Outlier
changed the title
Future-Outlier
changed the title
added 2 commits
September 11, 2023 15:05
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
force-pushed
the
sync-agent-do-task-function
branch
from
327bac4
to
004a20f
Compare
|
@pingsutw, Can you help approve this test? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 75.92% 78.48% +2.55%
==========================================
Files 18 18
Lines 1458 1250 -208
==========================================
- Hits 1107 981 -126
+ Misses 294 212 -82
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kumare3
reviewed
Sep 26, 2023
protos/flyteidl/admin/agent.proto
Outdated
| // Template of the task that encapsulates all the metadata of the task. | ||
| core.TaskTemplate template = 2; | ||
| // Prefix for where task output data will be written. (e.g. s3://my-bucket/randomstring) | ||
| string output_prefix = 3; |
There was a problem hiding this comment.
yes, I think you are right
8 tasks
Signed-off-by: Future Outlier <[email protected]>
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As title.
Type
Are all requirements met?
Tracking Issue
Follow-up issue
https://github.com/flyteorg/flyteidl/pull/413/files#diff-70bc292dedbce9072f9a4bbd20e9ea6c686baf766bcade96b389dac9f4fd553b