Improve error message for get signed url failure #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
eapolinario
reviewed
Aug 13, 2024
pingsutw
commented
Aug 14, 2024
| @@ -113,7 +113,6 @@ def pretty_print_traceback(e: Exception, verbosity: int = 1): | |||
| Print the traceback in a nice formatted way if verbose is set to True. | |||
| """ | |||
| console = Console() | |||
| tb = e.__cause__.__traceback__ if e.__cause__ else e.__traceback__ | |||
There was a problem hiding this comment.
I think showing all the stack trace is better, not just the e.cause.
There was a problem hiding this comment.
Can you add a few examples of the before and after this change?
There was a problem hiding this comment.
pyflyte -vv register flyte-example/getting_started.py
eapolinario
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
The error message is not clear.
What changes were proposed in this pull request?
Add a new exception (FlyteSystemUnavailableException). flytekit will raise this exception when the cluster is not available.
How was this patch tested?
pyflyte register without running a cluster locally
Setup process
Screenshots
Before
After:
Check all the applicable boxes
Related PRs
NA
Docs link
NA