Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip_extra_index_url as a supported parameter in default builder #2704

Merged

Conversation

thomasjpfan
Copy link
Member

Why are the changes needed?

pip_extra_index_url was added in #2636, but the warning was not removed.

What changes were proposed in this pull request?

This PR adds pip_extra_index_url as a supported option.

How was this patch tested?

Ran image builder with no warning.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (a8f68d7) to head (8e7e101).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
- Coverage   78.91%   78.87%   -0.05%     
==========================================
  Files         316      187     -129     
  Lines       24965    19232    -5733     
  Branches     4012     4017       +5     
==========================================
- Hits        19702    15169    -4533     
+ Misses       4548     3360    -1188     
+ Partials      715      703      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit ae7d583 into flyteorg:master Aug 23, 2024
99 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants