Provide upper bound to great expectations #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla and
Future-Outlier
as code owners
eapolinario
reviewed
Aug 28, 2024
| @@ -196,7 +196,7 @@ def to_python_value( | |||
| ge_conf = GreatExpectationsFlyteConfig(**conf_dict) | |||
|
|
|||
| # fetch the data context | |||
| context = ge.data_context.DataContext(ge_conf.context_root_dir) # type: ignore | |||
| context = ge.get_context(context_root_dir=self._context_root_dir) # type: ignore | |||
There was a problem hiding this comment.
should we require greatexpectations>=1.0.0 in setup.py?
There was a problem hiding this comment.
I made it 0.18.0 since get_context is available in 0.18.X: https://github.com/great-expectations/great_expectations/blob/0.18.0/great_expectations/__init__.py
eapolinario
previously approved these changes
Aug 28, 2024
pingsutw
previously approved these changes
Aug 28, 2024
pingsutw
previously approved these changes
Aug 28, 2024
wild-endeavor
previously approved these changes
Aug 28, 2024
eapolinario
previously approved these changes
Aug 28, 2024
|
The test is still failing |
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
dismissed stale reviews from eapolinario, wild-endeavor, and pingsutw
via
26dcd41
thomasjpfan
force-pushed
the
thomasjpfan/fix_great_expectations_ci
branch
from
ee5b96d
to
26dcd41
Compare
thomasjpfan
changed the title
eapolinario
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fixes CI issue with a breaking change in great expectations 1.0.0.