Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

updating interruptibleFailureThreshold to int32 to allow negative values #403

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

hamersaw
Copy link
Contributor

TL;DR

Allowing negative values to act as complementary. For example -1 will allow all but the last attempt to be interruptible, -2 means the last two, etc.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

flyteorg/flytepropeller#596

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.33% 🎉

Comparison is base (9bf0fb9) 62.91% compared to head (96d0cb9) 64.24%.

❗ Current head 96d0cb9 differs from pull request most recent head c548d23. Consider uploading reports for the commit c548d23 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   62.91%   64.24%   +1.33%     
==========================================
  Files         156      156              
  Lines       13154    10674    -2480     
==========================================
- Hits         8276     6858    -1418     
+ Misses       4257     3195    -1062     
  Partials      621      621              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
go/tasks/plugins/array/k8s/subtask_exec_context.go 83.18% <100.00%> (+1.36%) ⬆️

... and 135 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw hamersaw merged commit 445fc58 into master Sep 29, 2023
7 checks passed
@hamersaw hamersaw deleted the feature/simplify-retries branch September 29, 2023 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants