-
Notifications
You must be signed in to change notification settings - Fork 53
Return ResourceWrapper without pointer #407
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 62.73% 64.17% +1.43%
==========================================
Files 156 156
Lines 13173 10709 -2464
==========================================
- Hits 8264 6872 -1392
+ Misses 4284 3204 -1080
- Partials 625 633 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
edit: Re-opening these PRs as the automation failed. |
Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4132. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components. |
TL;DR
Worker in async cache panics because it fails to cast resource to
*ResourceWrapper
cache (*Resource) -> cast to (*Resource) // it works
s3 (Resource) -> cast to (*Resource) // Failed to do type casting since we unmarshall the resource to
Resource
here.We read the resource from s3 bucket after restarting the propeller (cache becomes empty).
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA