This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add a generic labeled gauge for K8s plugin resources #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Haytham AbuelFutuh <[email protected]>
Co-authored-by: Haytham AbuelFutuh <[email protected]>
…ller into plugin-manager-collector
EngHabu
previously approved these changes
May 28, 2020
added 2 commits
May 28, 2020 17:18
wild-endeavor
changed the title
added 5 commits
May 29, 2020 13:05
added 2 commits
June 4, 2020 10:25
EngHabu
reviewed
Jun 9, 2020
Co-authored-by: Haytham AbuelFutuh <[email protected]>
This reverts commit d21aacf.
added 2 commits
June 10, 2020 15:59
kumare3
reviewed
Jun 17, 2020
| Scope promutils.Scope | ||
|
|
||
| // Meta timer - this times each collection cycle to measure how long it takes to collect the levels GaugeVec below | ||
| CollectorTimer *labeled.StopWatch |
There was a problem hiding this comment.
is this a prometheus collector?
There was a problem hiding this comment.
if not have you considered using - https://godoc.org/github.com/prometheus/client_golang/prometheus#Collector
There was a problem hiding this comment.
stopwatches are defined in flytestdlib, but they're basically Summary objects https://github.com/lyft/flytestdlib/blob/c963e9ff8fc9bb46f169c43b923af07d6c5bf71e/promutils/scope.go#L72
kumare3
reviewed
Jun 17, 2020
| } | ||
|
|
||
| func (r *ResourceLevelMonitor) RunCollector(ctx context.Context) { | ||
| ticker := time.NewTicker(resourceLevelMonitorCycleDuration) |
There was a problem hiding this comment.
you mean inside the goroutine right? If I add it here, the ticker will just stop and it'll never run.
There was a problem hiding this comment.
added it inside.
kumare3
reviewed
Jun 23, 2020
Co-authored-by: Ketan Umare <[email protected]>
kumare3
approved these changes
Jun 24, 2020
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
# TL;DR Adds a generic labeled gauge for K8s plugin resources ## Type - [ ] Bug Fix - [x] Feature - [ ] Plugin ## Are all requirements met? - [x] Code completed - [x] Smoke tested - [x] Unit tests added - [x] Code documentation added - [x] Any pending items have an associated Issue ## Complete description * We are adding a generic utility to emit gauge metrics in the `plugin_manager` using the labeled gauges now found in flytestdlib. * Henceforth, a goroutine will be spun up that will create a `ResourceLevelMonitor` for each type that a plugin registers. * Changing the existing gauge collecting utilty for FlyteWorkflow CRD objects to use the same labeled gauge. * We may wish to combine these in the future but as their aggregations are different, we are keeping them separate for now. ## Tracking Issue flyteorg/flyte#311 ## Follow-up issue NA
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds a generic labeled gauge for K8s plugin resources
Type
Are all requirements met?
Complete description
plugin_managerusing the labeled gauges now found in flytestdlib.ResourceLevelMonitorfor each type that a plugin registers.Tracking Issue
flyteorg/flyte#311
Follow-up issue
NA