Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Revert "Pass command-line arguments" #218

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Jan 26, 2021

Reverts #193

I'm not sure why this wasn't caught in the End-To-End tests but running Propeller in a cluster goes into a crashloop because of this change...
The error is:

strict mode is on but received keys [map[add_dir_header:false alsologtostderr:false config:/etc/flyte/config/*.yaml ginkgo:map[debug:false dryrun:false failfast:false failonpending:false flakeattempts:1 focus: nocolor:false noisypendings:true noisyskippings:true parallel:map[node:1 streamhost: synchost: total:1] progress:false randomizeallspecs:false regexscansfilepath:false reportfile: reportpassed:false seed:1611672198 skip: skipmeasurements:false slowspecthreshold:5 succinct:false trace:false v:false] help:false kubeconfig: log_backtrace_at::0 log_dir: log_file: log_file_max_size:1800 logtostderr:true master: skip_headers:false skip_log_headers:false stderrthreshold:2 v:0 vmodule:]] to decode with no config assigned to receive them: failed strict mode check

I'm not sure why... these flags are not being passed to propeller but they are part of klog (line 83)... could that be the reason? It needs further debugging. If you've the time to dig deeper, that would be great. Otherwise, unfortunately, this will go back to our backlog..

@anandswaminathan anandswaminathan merged commit 7447a5d into flyteorg:master Jan 26, 2021
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants