This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
September 12, 2023 21:23
pingsutw
changed the title
Enqueue only running tasks
only Enqueue non-terminal task tasks
Sep 12, 2023
pingsutw
changed the title
only Enqueue non-terminal task tasks
Only enqueue non-terminal task tasks
Sep 12, 2023
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 67.88% 67.61% -0.27%
==========================================
Files 69 69
Lines 4110 4113 +3
==========================================
- Hits 2790 2781 -9
- Misses 1157 1167 +10
- Partials 163 165 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
pingsutw
changed the title
Only enqueue non-terminal task tasks
Only enqueue non-terminal tasks
Sep 13, 2023
Signed-off-by: Kevin Su <[email protected]>
kumare3
reviewed
Sep 13, 2023
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
EngHabu
approved these changes
Sep 13, 2023
This was referenced Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
I find that Propeller tries to process the completed task from the
workqueue
because we enqueue the completed item. we should check the item's status before we enqueue them.Problem:
After:
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA