Skip to content

Commit

Permalink
Remove unnecessary Java runtime dependency of non-binary rules
Browse files Browse the repository at this point in the history
Work towards bazelbuild#17085
Work towards bazelbuild/rules_java#64
Split off from bazelbuild#18262
  • Loading branch information
fmeum committed Jun 8, 2023
1 parent 655849b commit 4a02190
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public Metadata getMetadata() {
return RuleDefinition.Metadata.builder()
.name("$java_base_rule")
.type(RuleClassType.ABSTRACT)
.ancestors(JavaToolchainBaseRule.class, JavaRuntimeBaseRule.class)
.ancestors(JavaToolchainBaseRule.class)
.build();
}
}
Expand Down Expand Up @@ -461,6 +461,7 @@ public Metadata getMetadata() {
.type(RuleClassType.ABSTRACT)
.ancestors(
JavaRule.class,
JavaRuntimeBaseRule.class,
// java_binary and java_test require the crosstool C++ runtime
// libraries (libstdc++.so, libgcc_s.so).
// TODO(bazel-team): Add tests for Java+dynamic runtime.
Expand Down

0 comments on commit 4a02190

Please sign in to comment.