Fix a segfault in test on glibc 2.26 #551

fmtlib · Feb 3, 2018 · 5d8ba81 · 5d8ba81
1 parent a9f810c
commit 5d8ba81
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/test/util-test.cc b/test/util-test.cc
@@ -743,9 +743,22 @@ TEST(UtilTest, FormatSystemError) {
   fmt::format_system_error(message, EDOM, "test");
   EXPECT_EQ(fmt::format("test: {}", get_system_error(EDOM)),
             to_string(message));
-  message.resize(0);
-  fmt::format_system_error(
-        message, EDOM, fmt::string_view(0, std::numeric_limits<size_t>::max()));
+  message = fmt::memory_buffer();
+
+  // Check if std::allocator throws on allocating max size_t / 2 chars.
+  size_t max_size = std::numeric_limits<size_t>::max() / 2;
+  bool throws_on_alloc = false;
+  try {
+    std::allocator<char> alloc;
+    alloc.deallocate(alloc.allocate(max_size), max_size);
+  } catch (std::bad_alloc) {
+    throws_on_alloc = true;
+  }
+  if (!throws_on_alloc) {
+    fmt::print("warning: std::allocator allocates {} chars", max_size);
+    return;
+  }
+  fmt::format_system_error(message, EDOM, fmt::string_view(0, max_size));
   EXPECT_EQ(fmt::format("error {}", EDOM), to_string(message));
 }