Remove unnecessary dllexport

fmtlib · Apr 16, 2021 · 8bc4550 · 8bc4550
1 parent 9260114
commit 8bc4550
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/include/fmt/core.h b/include/fmt/core.h
@@ -223,9 +223,6 @@
 #ifndef FMT_EXTERN_TEMPLATE_API
 #  define FMT_EXTERN_TEMPLATE_API
 #endif
-#ifndef FMT_INSTANTIATION_DECL_API
-#  define FMT_INSTANTIATION_DECL_API FMT_API
-#endif
 
 #ifndef FMT_HEADER_ONLY
 #  define FMT_EXTERN extern

diff --git a/include/fmt/format.h b/include/fmt/format.h
@@ -995,7 +995,7 @@ FMT_INLINE uint16_t bsr2log10(int bsr) {
   return data[bsr];
 }
 
-FMT_EXTERN template struct FMT_INSTANTIATION_DECL_API basic_data<void>;
+FMT_EXTERN template struct basic_data<void>;
 
 // This is a struct rather than an alias to avoid shadowing warnings in gcc.
 struct data : basic_data<> {};

diff --git a/src/format.cc b/src/format.cc
@@ -55,8 +55,6 @@ vformat_to(buffer<char>&, string_view,
                type_identity_t<char>>>);
 }  // namespace detail
 
-// Clang doesn't allow dllexport on template instantiation definitions:
-// https://reviews.llvm.org/D61118.
 template struct detail::basic_data<void>;
 
 // Workaround a bug in MSVC2013 that prevents instantiation of format_float.