Add a comment to clarify why convert to unsigned

fmtlib · Jan 26, 2016 · ae6368c · ae6368c
1 parent bb7a80b
commit ae6368c
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/format.cc b/format.cc
@@ -328,6 +328,9 @@ class ArgConverter : public fmt::internal::ArgVisitor<ArgConverter<T>, void> {
     } else {
       if (is_signed) {
         arg_.type = Arg::LONG_LONG;
+        // Convert value to unsigned type before converting to long long for
+        // consistency with glibc's printf even though in general it's UB:
+        //   std::printf("%lld", -42);  // prints "4294967254"
         arg_.long_long_value =
             static_cast<typename fmt::internal::MakeUnsigned<U>::Type>(value);
       } else {