Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_dynamic_spec compares signed integers against unsigned #1319

Closed
rwy7 opened this issue Sep 19, 2019 · 2 comments
Closed

set_dynamic_spec compares signed integers against unsigned #1319

rwy7 opened this issue Sep 19, 2019 · 2 comments

Comments

@rwy7
Copy link

rwy7 commented Sep 19, 2019

the problematic comparison is at include/fmt/format.h:2091, resulting in this message:

../external/fmt/include/fmt/format.h:2091:17: warning: comparison of integer expressions of different signedness: ‘long long unsigned int’ and ‘int’ [-Wsign-compare]
 2091 |   if (big_value > max_value<int>()) eh.on_error("number is too big");

The complete error message is quite large due to template expansion.
vitaut added a commit that referenced this issue Sep 19, 2019
@vitaut
Fix a warning (#1319) and simplify code
3b83fcd
vitaut added a commit that referenced this issue Sep 19, 2019
@vitaut
Fix a warning (#1319) and simplify code
758446c
@vitaut
Copy link
Contributor

vitaut commented Sep 20, 2019

Should be fixed in 758446c. Thanks for reporting!

@vitaut vitaut closed this as completed Sep 20, 2019
@rwy7
Copy link
Author

rwy7 commented Sep 20, 2019

Thank you for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @rwy7