Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming internal namespace to detail #1538

Closed
vitaut opened this issue Jan 29, 2020 · 0 comments
Closed

Consider renaming internal namespace to detail #1538

vitaut opened this issue Jan 29, 2020 · 0 comments

Comments

@vitaut
Copy link
Contributor

vitaut commented Jan 29, 2020

internal might be causing issues in C++/CLI (#1005). This is a breaking change so will have to wait until the next major release.
vitaut added a commit that referenced this issue May 10, 2020
@vitaut
internal -> detail (#1538)
8069265
@vitaut vitaut closed this as completed May 10, 2020
candrews added a commit to candrews/spdlog that referenced this issue Jul 6, 2020
@candrews
Define FMT_USE_INTERNAL for fmt 7.0.0
7212aa4 
fmt 7.0.0 renamed the internal namespace to detail. The former is still provided as an alias if the FMT_USE_INTERNAL macro is defined.

See: fmtlib/fmt#1538
@candrews candrews mentioned this issue Jul 6, 2020
Closed
candrews added a commit to candrews/spdlog that referenced this issue Jul 6, 2020
@candrews
fmt 7.0.0 renamed the internal namespace to detail.
22bee81 
See: fmtlib/fmt#1538
@candrews candrews mentioned this issue Jul 6, 2020
Merged
@github-actions github-actions bot mentioned this issue Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vitaut