Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make constexpr remove_prefix gcc version check tighter #648

Closed
llchan opened this issue Feb 12, 2018 · 1 comment
Closed

Make constexpr remove_prefix gcc version check tighter #648

llchan opened this issue Feb 12, 2018 · 1 comment

Comments

@llchan
Copy link

llchan commented Feb 12, 2018 •
edited
Loading

Looks like std::experimental::basic_string_view::remove_prefix isn't constexpr until gcc 7.3. Should just be a matter of updating the FMT_GCC_VERSION >= 700 check at the top of core.h.

Links to the relevant lines in gcc source code:
7.2.0
7.3.0
vitaut added a commit that referenced this issue Feb 14, 2018
@vitaut
Make constexpr remove_prefix gcc version check tighter (#648)
229887b
@vitaut
Copy link
Contributor

vitaut commented Feb 14, 2018

Fixed, thanks!

@vitaut vitaut closed this as completed Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llchan @vitaut