Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed/unsigned mismatch #95

Closed
seanmiddleditch opened this issue Feb 6, 2015 · 1 comment
Closed

signed/unsigned mismatch #95

seanmiddleditch opened this issue Feb 6, 2015 · 1 comment

Comments

@seanmiddleditch
Copy link

Sometime after commit 531ee61 and the current HEAD, the code now results in a W4018 error when compiling in VC 18 (2013) with /W3 /WX.

1>cppformat\format.cc(628): error C2220: warning treated as error - no 'object' file generated
1>          cppformat\format.cc(879) : see reference to function template instantiation 'void fmt::BasicWriter<char>::write_str<char>(const fmt::internal::Value::StringValue<char> &,const fmt::FormatSpec &)' being compiled
1>          cppformat\format.cc(879) : see reference to function template instantiation 'void fmt::BasicWriter<char>::write_str<char>(const fmt::internal::Value::StringValue<char> &,const fmt::FormatSpec &)' being compiled
1>          cppformat\format.cc(745) : while compiling class template member function 'void fmt::internal::PrintfFormatter<Char>::format(fmt::BasicWriter<Char> &,fmt::BasicStringRef<Char>,const fmt::ArgList &)'
1>          with
1>          [
1>              Char=char
1>          ]
1>          c:\users\sean\documents\projects\cppformat\format.h(2178) : see reference to function template instantiation 'void fmt::internal::PrintfFormatter<Char>::format(fmt::BasicWriter<Char> &,fmt::BasicStringRef<Char>,const fmt::ArgList &)' being compiled
1>          with
1>          [
1>              Char=char
1>          ]
1>          cppformat\format.cc(1120) : see reference to class template instantiation 'fmt::internal::PrintfFormatter<Char>' being compiled
1>          with
1>          [
1>              Char=char
1>          ]
1>cppformat\format.cc(628): warning C4018: '<' : signed/unsigned mismatch
vitaut added a commit that referenced this issue Feb 6, 2015
@vitaut
Copy link
Contributor

vitaut commented Feb 6, 2015

Fixed in 5925441. Thanks for reporting!

@vitaut vitaut closed this as completed Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants