Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined reference & and one warning #1206

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Fix undefined reference & and one warning #1206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5ed0b9
Fix Warning
HazardyKnusperkeks Jun 24, 2019
0aa7b73
Export exceptions destructors
HazardyKnusperkeks Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/fmt/format-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ FMT_FUNC Char internal::thousands_sep_impl(locale_ref) {
}
#endif

FMT_FUNC format_error::~format_error() FMT_NOEXCEPT {}
FMT_FUNC system_error::~system_error() FMT_NOEXCEPT {}
FMT_API FMT_FUNC format_error::~format_error() FMT_NOEXCEPT {}
FMT_API FMT_FUNC system_error::~system_error() FMT_NOEXCEPT {}

FMT_FUNC void system_error::init(int err_code, string_view format_str,
format_args args) {
Expand Down
4 changes: 2 additions & 2 deletions include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ typedef basic_memory_buffer<char> memory_buffer;
typedef basic_memory_buffer<wchar_t> wmemory_buffer;

/** A formatting error such as invalid format string. */
class format_error : public std::runtime_error {
class FMT_API format_error : public std::runtime_error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the destructor needs to be marked with FMT_API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my first pull request, but then I got undefined reference to the vtable, which is not exported in that case. If you know how to export the vtable explicitly I will change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK then.

public:
explicit format_error(const char* message) : std::runtime_error(message) {}
explicit format_error(const std::string& message)
Expand Down Expand Up @@ -2198,7 +2198,7 @@ class arg_formatter : public internal::arg_formatter_base<Range> {
An error returned by an operating system or a language runtime,
for example a file opening error.
*/
class system_error : public std::runtime_error {
class FMT_API system_error : public std::runtime_error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

private:
FMT_API void init(int err_code, string_view format_str, format_args args);

Expand Down