Support color printing strings with zero bytes #1356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a clean up after fmtlib#1351.
vitaut
requested changes
Oct 12, 2019
| @@ -503,8 +503,7 @@ void vprint(std::FILE* f, const text_style& ts, const S& format, | |||
| basic_format_args<buffer_context<Char> > args) { | |||
| basic_memory_buffer<Char> buf; | |||
| internal::vformat_to(buf, ts, to_string_view(format), args); | |||
| buf.push_back(Char(0)); | |||
| internal::fputs(buf.data(), f); | |||
| std::fwrite(buf.data(), 1, buf.size(), f); | |||
There was a problem hiding this comment.
To handle wchar_t correctly on Windows this should be fputws if Char is wchar_t (#1243). This will truncate output on NUL chars but I don't think we should worry about this. Also use fwrite_fully for char to handle I/O errors.
|
Closing because, as commented earlier, I think we should continue using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean up after #1351.